search

rand256 / valetudo

Valetudo RE - experimental vacuum software, cloud free
Apache License 2.0
667 stars 73 forks source link

Rework of the resume-button on home tab PR#165 #348

Closed pidator closed 3 years ago

pidator commented 3 years ago

Following the ideas of https://github.com/rand256/valetudo/issues/165#issuecomment-702598944 in the orignially PR https://github.com/rand256/valetudo/pull/165 I've done a rework of the position of the resume button on home tab. The button is located on the same position like the pause button now, but only visible in paused or error states:

Robot running: run

Robot pausing: pause

jhesketh commented 3 years ago

Thanks for this :+1:

Is it possible to know what action the resume will do? For example, can the button say "Resume returning to dock" or "Resume zoned cleanup" etc.

rand256 commented 3 years ago

It should resume returning to dock and zoned/segment/full cleaning. Fairly, in most cases it will simply do what "start" button does, in except for returning to dock. Just in a bit more clear way.

pidator commented 3 years ago

Is it possible to know what action the resume will do?

After pushing the pause button you'll see the current state of the robot on top of home tab Paused with an following slash and then the name of the actions that is paused (e.g. Paused / Rooms cleaning). Additional you'll still able to see the areas (rooms/zones) marked on the map that are still going to be cleaned. So from my point of view there's no need to further implement this state somewhere else.

jhesketh commented 3 years ago

Ah, I was unaware of that message. That's helpful - thanks!