search

rand256 / valetudo

Valetudo RE - experimental vacuum software, cloud free
Apache License 2.0
667 stars 73 forks source link

Timed Zone Cleaning #4

Closed nicedevil007 closed 5 years ago

nicedevil007 commented 5 years ago

Hey rand256 :D Here I'm again! Thx first for support! Realy good job so far.

Today I added 2 testtimers for zoned cleaning.

image

And here is the result:

image

Is it even possible to change the time on this page as well? The Timezonesetting doesn't help at all because it still uses GMT instead of GMT+1?

rand256 commented 5 years ago

With 0b72a9ce177843e27e5dd8d7be806909aa6655ef it should show cleaning time using timezone selected in the vacuum's settings.

nicedevil007 commented 5 years ago

I will test it. The time in CLI is correct on my S50. But I think valetudo is using an other time. Will report back :)

nicedevil007 commented 5 years ago

Ok tested. Set the robot to clean a test area at 17:35, it doesn't start. I think it will start at 18:35 now.

image

Oh and an enhancement :D What about an Edit button as you did for the Zones to change the timersettings or days etc, or even the name?

rand256 commented 5 years ago

Please make sure you have correct timezone set in vacuum's firmware (that is used for normal clean timers as well). It's may be different from the timezone at onboard linux system. It is set at "settings" -> "timers" -> "gear icon".

Editing zoned timers isn't nearly as easy as editing zones. I agree though it should be done some day.

nicedevil007 commented 5 years ago

I double checked it again. The timezone is set to Europe/Berlin what's correct for me :)

image

and here CLI:

image

nicedevil007 commented 5 years ago

Ok, now it is 18:35 => S50 started Testzone cleaning...

nicedevil007 commented 5 years ago

Maybe it is a problem with summer/winter time?

rand256 commented 5 years ago

Yes, node-cron module seems doesn't support Daylight Saving Time at all.

nicedevil007 commented 5 years ago

Ok, then we don't have a chance at all to fix that right? Isn't it possible to determine which time is set right now and substract 1 hour from that?

rand256 commented 5 years ago

No it isn't since there's huge amount of timezones in the world and you won't be able to track them all. So in cf158076fd4fd468de29a4168ba3f2f9940425f4 I've replaced cron module with the one supporting Daylight Saving Time. Probably should get better. In my country there's no DST now, though.

nicedevil007 commented 5 years ago

The Winter/Summertime will be abandoned in europe in the near future :) But isn't it easy to compare the time of the linux system with the setup timer for zoned cleaning? The time in ubuntu should be always the right one, using my Sophos UTM as NTP server :)

oh forgot: will test the new release as always :) you can't imagine how much we (my girlfriend as well) like your version of valetudo!

nicedevil007 commented 5 years ago

Ok Rand256, my test was setup for 19:00... the robot started at exact 19:00 :) My girlfriend is lucky now hehe.

One little improvement... a button to enable autorefresh of the map while the robot is running around the flat?

rand256 commented 5 years ago

The thing is not everyone can setup required timezone in linux console. Setting it via the website is much easier.

Regarding refreshing the map, it should be refreshing automatically during the cleaning (and for me it surely does work fine). If it doesn't for you, please open another ticket.