search

rand256 / valetudo

Valetudo RE - experimental vacuum software, cloud free
Apache License 2.0
664 stars 73 forks source link

Timesync is too verbose #458

Closed dmlemos closed 2 years ago

dmlemos commented 2 years ago

The timesync is too verbose. It spams the system log.

How to Reproduce

  1. Turn the robot on :)
  2. Watch the valetudo system log: 
    2021-08-05T13:24:02.791Z Timesync packet received
2021-08-05T12:54:02.791Z Timesync packet received
2021-08-05T12:24:02.791Z Timesync packet received
2021-08-05T11:54:02.791Z Timesync packet received
2021-08-05T11:24:02.791Z Timesync packet received
2021-08-05T10:54:02.791Z Timesync packet received
2021-08-05T10:24:02.791Z Timesync packet received
2021-08-05T09:54:02.791Z Timesync packet received
2021-08-05T09:24:02.791Z Timesync packet received
2021-08-05T08:54:02.790Z Timesync packet received
2021-08-05T08:24:02.791Z Timesync packet received
2021-08-05T07:54:02.791Z Timesync packet received
2021-08-05T07:24:02.791Z Timesync packet received
2021-08-05T06:54:02.791Z Timesync packet received
2021-08-05T06:24:02.791Z Timesync packet received
2021-08-05T05:54:02.791Z Timesync packet received
2021-08-05T05:24:02.791Z Timesync packet received
2021-08-05T04:54:02.791Z Timesync packet received
2021-08-05T04:24:02.791Z Timesync packet received
2021-08-05T03:54:02.791Z Timesync packet received
2021-08-05T03:24:02.791Z Timesync packet received
2021-08-05T02:54:02.791Z Timesync packet received
2021-08-05T02:24:02.791Z Timesync packet received

This happens every time the robot gets rebooted, which is every day.

Expected behavior These type of messages should belong to debug mode imo. Since there isn't, I would omit them.

Vacuum Model: Roborock S55

Valetudo Version: Valetudo RE 0.10.7

rand256 commented 2 years ago

This doesn't harm anyone and rather shows that connection between valetudo and manufacturer's software is still alive.