randallnhr / pe

0 stars 0 forks source link

Overzealous input check for tag names #11

Open randallnhr opened 1 year ago

randallnhr commented 1 year ago

image.png

image.png

Problem: The delete_tag command does not have a case insensitive check on tag names. Example delete_tag 10 Pet does not recognise that the person at index 10 has a tag pet.

nus-se-script commented 1 year ago

Team's Response

Severity downgrade (Medium -> Low): According to definition of severity.low, this flaw should lie under severity.low since the flaw is unlikely to affect normal operations of the product and appears only in rare situations, as it would only affect users who enter the same tag with different cases. Additionally, the flaw causes only minor inconvenience, as users can still use the application despite the case-sensitive nature of the tag feature implemented. Bug type change (FunctionalityBug -> FeatureFlaw): this behaviour is what I expect when I implement the command, this looks more like a feature flaw to me than a functionality bug.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]