randallnhr / pe

0 stars 0 forks source link

Overzealous input check for phone numbers in add command #4

Open randallnhr opened 1 year ago

randallnhr commented 1 year ago

Problem:

  1. Users are unable to add the country code such as +65 to the phone number prefix. image.png

  2. Users are not able to add 2 phone numbers for a single person.

image.png

Reason:

  1. I think it might be better to allow users to use the + symbol in the phone number as there are instances where the customer's phone number is not a local number.

  2. Some customer might have multiple phones that they use and might want to give both in case they are uncontactable by any one of it.

soc-se-bot commented 1 year ago

Team's Response

Thanks for your suggestion - more flexible & extensive input data checks were not a priority during previous development, but the scenarios raised here are reasonable real-world use cases. Improved phone number checks could be a valuable feature for future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]