random-parts / Team-Sports-RSVP

Google Sheets add-on for ezleagues.ezfacility.com team schedules
Apache License 2.0
2 stars 0 forks source link

Deleted game misaligned responses #14

Open Haliboot opened 7 years ago

Haliboot commented 7 years ago

Last Friday's walking dead game was cancelled. The remaining games moved one space to left in the column headings, but the responses were not changed, so that responses to deleted game are now under the heading for the next game, ... and every column after that is similarly off by one

random-parts commented 7 years ago

I was concerned that may happen. If the online schedule deletes the game before the script picks up the reschedule notice, the script wouldnt know the game ever existed. https://github.com/random-parts/Team-Sports-RSVP/blob/31333a57e59d7d4a4d78e589f56c437d5d5f72df/src/services/ScheduleService.js#L135-L143

Maybe adding an extra schedule compare process before re-writting the displayed schedule. Was thinking that that scenario would be such an outlier that I could save the extra processing time it would take to run each time. Chalk it up to another lesson in learning that real world use/processes do not end running in the neat and tidy way they do in testing environments