search

random-parts / Team-Sports-RSVP

Google Sheets add-on for ezleagues.ezfacility.com team schedules
Apache License 2.0
2 stars 0 forks source link

Question: Does it handle the case of multiple games on the same day, or games that are less than a week apart? #18

Closed Haliboot closed 7 years ago

Haliboot commented 7 years ago

Will it send email for all relevant games, or will the soonest game "hide" the other games? I haven't tested this, but it seemed like a case that could easily be overlooked, so I thought I'd ask.

random-parts commented 7 years ago

It will send an email for each game in the next/upcoming day a game is scheduled for. That would be a problem for games scheduled less than two days apart as they would not get an email at all. The first game would block it. https://github.com/random-parts/Team-Sports-RSVP/blob/a506f5eccebc152c55871329bf7004c5e3fc8ad7/src/services/ScheduleService.js#L149-L190

What do you think about a change to have the emailer send emails to any game that is 3 days out [and/or 1, 2 days (this will be adjustable once a settings UI is in place)] , instead of just finding the next game day. Would probably simplify the task as well.

Haliboot commented 7 years ago

Yes, that would be the right thing to do. Thanks,

On Thu, Sep 7, 2017 at 2:46 PM, random-parts notifications@github.com wrote:

It will send an email for each game in the next/upcoming day a game is scheduled for. That would be a problem for games scheduled less than two days apart as they would not get an email at all. The first game would block it. https://github.com/random-parts/Team-Sports-RSVP/blob/ a506f5eccebc152c55871329bf7004c5e3fc8ad7/src/services/ ScheduleService.js#L149-L190

What do you think about a change to have the emailer send emails to any game that is 3 days out [and/or 1, 2 days (this will be adjustable once a settings UI is in place)] , instead of just finding the next game day. Would probably simplify the task as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/random-parts/Team-Sports-RSVP/issues/18#issuecomment-327904193, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad18TxWdIiZayDroiNMDMhgCHvjwebqnks5sgEgcgaJpZM4PQNN0 .