randomBrainstormer / MMM-GoogleCalendar

Google Calendar for MagicMirror²
MIT License
69 stars 46 forks source link

Add properties for being compatible with default calendar module broadcasting #46

Closed eouia closed 11 months ago

eouia commented 11 months ago

The notifications of this module lack some fields of event, so it is not fully compatible with that of the default calendar module. Therefore, in other 3rd party modules (e.g. MMM-CalendarExt3 suites), there would be some issues.

This PR adds startDate, endDate, title and fullDayEvent to the event which will be broadcasted.

eouia commented 11 months ago

Is there any issue with this PR?

randomBrainstormer commented 11 months ago

Is there any issue with this PR?

Hi @eouia

Thank you for the refactoring; the new code is definitely more concise and streamlined. I appreciate the effort!

I'll be approving and merging the PR shortly. I appreciate contributors like you who help improve our project. Thank you again!