search

randombit / botan

Cryptography Toolkit
https://botan.randombit.net
BSD 2-Clause "Simplified" License
2.49k stars 554 forks source link

Upstream a CMake Find Module #3490

Closed securitykernel closed 8 months ago

securitykernel commented 1 year ago

CMake provides so-called "find modules" in order to make it easier for downstream users of software packages to find header files, libraries to link against, etc. CMake ships find modules for many standard software packages, e.g., Boost, OpenSSL, curl and many more. We have been writing our own find module for Botan 2.x and would now have to write our own find module for Botan 3.x when switching. Others are doing the same, e.g., KeePassXC, rnp and more. We even link to rnp's FindBotan2.cmake from our wiki.

Can we just upstream one of these to the CMake project to be included with the CMake distribution? That would make it really easy for Botan users on CMake to integrate Botan into their builds and we get rid of all these CMake script duplicates.

randombit commented 1 year ago

Yeah this makes sense to include. Ideally we'd have some way of testing it.

securitykernel commented 11 months ago

Asked the rnp people if we can upstream theirs https://github.com/rnpgp/rnp/issues/2121.