search

randombit / botan

Cryptography Toolkit
https://botan.randombit.net
BSD 2-Clause "Simplified" License
2.6k stars 570 forks source link

[C++] Botan build failed with error C2039 #4278

Closed JonLiu1993 closed 4 months ago

JonLiu1993 commented 4 months ago

Hello, I'm a member of Microsoft VCPKG, when I built botan:x64-windows in an internal version of Visual Studio, it failed with following errors:

build\include\internal\botan/internal/pcurves_id.h(57): error C2039: 'string': is not a member of 'std'

This issue caused by the STL PR: https://github.com/microsoft/STL/pull/4633, and according to the recommendations of the STL developers, the affected files need to include the Standard header.

I have applied this change in vcpkg by https://github.com/microsoft/vcpkg/pull/40192. Since this VS internal version has not been released yet, I am submitting this issue just to inform you.

randombit commented 4 months ago

Thank you for the report. On master this has already been resolved #4250 so I’m closing this as completed.