search

randomhost / teamspeak-dark

A dark theme for TeamSpeak 3 which looks surprisingly similar to another popular voice communication software.
https://github.random-host.tv/teamspeak-dark/
BSD 3-Clause "New" or "Revised" License
58 stars 8 forks source link

Context menu entries "active" state not visible #3

Closed Chi-Yu closed 4 years ago

Chi-Yu commented 7 years ago

Options like "Channel Commander" and "Priority Speaker" can be toggled "active" and should reflect that state visually.

The default theme uses a different background color behind the icon. Maybe that's a good option.

Chi-Yu commented 7 years ago

I could use some input how to address this issue without breaking other menu items.

Chi-Yu commented 6 years ago

Seeing the weird things that are going on here, we may need an upstream fix. Something weird is going on with the icons.

Others themes appear to avoid the issue by simply not addressing it which means they suffer from the same missing "active" style.

Bluscream commented 6 years ago

Could you explain in more detail what the issue is?

Options like "Channel Commander" and "Priority Speaker" can be toggled "active" and should reflect that state visually.

The toolbar buttons or the "Client" -> "Rightclick" item's icons?

If you mean the actual context menu i have no problems distinguishing active/inactive

grafik

Same with the toolbar icons ![grafik](https://user-images.githubusercontent.com/3318223/33820008-88f087f8-de4d-11e7-890d-0c216da9ab52.png)

Seeing the weird things that are going on here, we may need an upstream fix. Something weird is going on with the icons.

Is this some new issue with one of the latest updates or was it always a thing?

Others themes appear to avoid the issue by simply not addressing it which means they suffer from the same missing "active" style.

Even the default theme?

The default theme uses a different background color behind the icon. Maybe that's a good option.

Why not use that? Would it require duplicating the icon files and theirfor waste a bunch of space?

Chi-Yu commented 6 years ago

I couldn't change the background color of the icon because that causes all sorts of glitches. I now changed the background color of the entire menu entry and that seems to work without side effects.

Example of disappearing icon when trying to style QMenu::indicator directly:

context-menu

And: Yes, the default themes shipped with the software use operating system defaults in menus which avoids the issue. You'll notice that the menu entries are highlighted in the default "hightlight" color of the operating system.

context-menu-classic

When you start messing around with the menus, things start to break.

Chi-Yu commented 4 years ago

The existing workaround is probably the best we can get. I'm closing this for now.