search

randomlylelo / thank-you-react

MIT License
1 stars 3 forks source link

Refactored Layout #11

Closed d3r3j3 closed 3 years ago

d3r3j3 commented 3 years ago

Sorry if variable names are bad.

Closes #6

ericluap commented 3 years ago

I think you might need to do a git pull cause there are some merge conflicts

randomlylelo commented 3 years ago

Yep there will be merge conflicts. Just run npm i and then keep the package-lock.json that it comes up with For second page, keep yours but add the three lines to the top of the function.

randomlylelo commented 3 years ago

So for src/SecondPage.js make

export default function SecondPage() {
  return (

into 

export default function SecondPage() {
  React.useEffect(() => {
        confetti({ colors: [ [ '#fe8c00', '#ffffff' ], [ '#fe8c00', '#ffffff' ] ], timeout: 25 });
    }, []);
  return (

and add 

import confetti from "./confetti.js";

to the top of the file.

randomlylelo commented 3 years ago

Everything else is good though!

ericluap commented 3 years ago

yeah should probably still do git pull though cause the most recent commit changed a dependency and that'll make sure it's updated and your commit isn't trying to revert that