randomoscars / randomoscars.github.io

Hit the button and get random categories and nominees from a random year
https://randomoscars.github.io
GNU General Public License v3.0
2 stars 2 forks source link

update oscar data based on imdb #1

Closed RikBoeykens closed 2 years ago

RikBoeykens commented 2 years ago

Got data from imdb and added it in the same format. Enriched the data with extra information:

RikBoeykens commented 2 years ago

added some more stuff. Should probably put it in branches (especially the stuff with the pictures is quite disruptive. If you want a 'clean' pull request with just some of the changes, let me know!

kyle-n commented 2 years ago

Awesome, thank you! I have family visiting at the moment so I’ll try to review all the changes Sunday or next week.

kyle-n commented 2 years ago

This looks good! Can you split this up into different PRs? Maybe one for the new JSON file data source and then one for the UI redesign? Sorry, just a lot to wrap my head around.

I'm excited though, this data looks really good.

RikBoeykens commented 2 years ago

Created a new pr with just the json: https://github.com/randomoscars/randomoscars.github.io/pull/2

RikBoeykens commented 2 years ago

some other UI improvements: does it make sense to add an option to filter on the 'main' categories: picture, director, writing, acting? Seems to me they'd rather talk about Best Actor than Best Art Direction-Set Decoration. I can add a "is_main" flag to those categories, and then there can be a checkbox on the form so the randomizer filters on those, as well as the dropdown

kyle-n commented 2 years ago

@RikBoeykens An interesting idea but I think it's a touch too much UI and logic complexity. I'll look over this PR.

kyle-n commented 2 years ago

@RikBoeykens After playing around with some different layouts, I think the images make the design too busy. It's cool that we have them but I think they're too distracting from the nominee list. The names are the most important thing, since that's what will be referenced on a theoretical podcast.

I think let's keep the links but simplify to just text. Also, I tried some new formatting to highlight the winner of each category.

Let me know what you think of the new highlighting and text-only design.

RikBoeykens commented 2 years ago

looks good!

RikBoeykens commented 2 years ago

I ran it now, and putting the winners in white means that (on my desktop) they don't show up!

kyle-n commented 2 years ago

😬 Yikes, good catch