search

randomouscrap98 / contentapi

A generic content system to make some kinda standard websites
GNU General Public License v3.0
8 stars 2 forks source link

UserService holds onto a db connection forever #138

Closed randomouscrap98 closed 2 years ago

randomouscrap98 commented 2 years ago

The user service is a static service (does it need to be??) and yet it holds onto a transient resource, which is a raw db connection. It DOES hold onto some concurrent stuff that should be singleton, like the registration and password change log. So, maybe convert it to use a db connection creator rather than holding onto one. I don't know how much impact this has though

randomouscrap98 commented 2 years ago

Fixed with something last night-ish idk