randomphrase / company-c-headers

Auto-completion for C/C++ headers using Company
GNU General Public License v2.0
76 stars 9 forks source link

fix/workaround: interference with yasnippet causes company-c-headers completion not work properly. #7

Open vibrys opened 9 years ago

vibrys commented 9 years ago

This is fix to issue https://github.com/randomphrase/company-c-headers/issues/6

company-c-headers, when on #include .. line, just turns off all yasnippets in progress. This prevents from yasnippet - company-c-headers interference.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-2.52%) to 70.69% when pulling ea9cf69a883ad30a286288a85e93d2f927d00527 on vibrys:vbrs into 0de5572a6fb522052de2982d79f798068d3af144 on randomphrase:master.

randomphrase commented 9 years ago

Hi @vibrys thanks for the pull request. I want to understand a bit more about this patch and why it is necessary. Honestly it looks like a bit of a hack to work around some other more fundamental incompatibility, perhaps between company mode and yasnippet? In which case my preference would definitely be to fix the problem at its source.