randomsync / robotframework-mqttlibrary

MQTT Keyword Library for Robot Framework
Apache License 2.0
25 stars 30 forks source link

Changed library to use background loop instead of manually looping #27

Open juha-ylikoski opened 3 years ago

juha-ylikoski commented 3 years ago

Addresses #25

This pull requests tries to fix problems with mqtt broker suddenly disconnecting. #4 thinks it might be related to looping mechanism somehow not working properly with robot.

Changes

TODO

Some pub/sub test cases are still failing. This is caused by them being synchronous.

Example:

Test case Publish a message with QOS 1 and validate that the message is received first sends a message to broker and reconnects, subscribes and tries to receive it. Due to this case using synchronous Subscribe And Validate message which was sent before has already timed out and cannot be received.

juha-ylikoski commented 3 years ago

@randomsync what is your opinion on these test cases failing due to them being synchronous when they maybe should not be. I could make them asynchronous but I'm not sure how we could test synchronous receiving (in my opinion it is too time sensitive and prone to failures).

Github is not letting me to include log.html but travis should have one shortly with the same issue.