randoragon
commented
4 months ago I'm aware of this issue, but I have not experienced it in years. And even when I did, it was very rare and usually fixed itself after a mousemode restart. So this is a bit strange.
I believe this means that the calls to XGrabKey failed, which iirc can happen e.g. if some other program is already grabbing the keys used by mousemode. To be honest, it is my bad that these calls are not error checked properly.
I can try to fix or at least prevent this situation (e.g. make mousemode print out a warning or an error when it is unable to grab the keys). If you have a way to reproduce, would you mind applying this patch and running mousemode in a terminal to see if there is any stderr output?
diff --git a/mousemode.c b/mousemode.c
index d1697af..3e9ce1d 100644
--- a/mousemode.c
+++ b/mousemode.c
@@ -99,6 +99,21 @@ int handleKeys()
return 1;
}
+int handler(Display *display, XErrorEvent *ev)
+{
+ fprintf(stderr, "--------------------------------\n");
+ fprintf(stderr, "Error event %lu %p!\n", ev->serial, ev);
+ fprintf(stderr, " ev->type: %d\n", ev->type);
+ switch (ev->error_code) {
+ case Success: fprintf(stderr, " ev->error_code: success.\n"); break;
+ case BadAccess: fprintf(stderr, " ev->error_code: BadAccess!\n"); break;
+ case BadValue: fprintf(stderr, " ev->error_code: BadValue!\n"); break;
+ case BadWindow: fprintf(stderr, " ev->error_code: BadWindow!\n"); break;
+ default: fprintf(stderr, " ev->error_code: unknown error %d!\n", ev->error_code); break;
+ }
+ return 0;
+}
+
void grabkey(int keysym)
{
KeyCode code;
@@ -121,6 +136,8 @@ int main()
signal(SIGTERM, termhandler);
signal(SIGINT, termhandler);
+ XSetErrorHandler(handler);
+
if (!(dpy = XOpenDisplay(NULL))) {
fprintf(stderr, "mousemode: failed to open display");
return 2;
hisacro
On some instances, mousemode doesn't entirely lock the keystrokes hence keys are registered as normal along with mouse movements. Unsure how to debug, this also persists on X restarts the only workaround so far is restarting my system. Any idea to proceed.