MSR - Fix file extraction

randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.

MIT License

2 stars 11 forks source link

MSR - Fix file extraction #108

Closed dyceron closed 10 months ago

dyceron commented 11 months ago

Seems like this bit of code in def _parse breaks extraction. Reverting this change allows for extraction to properly occur, but I do not know the side effects or if this is the best way to fix this issue.

Leaving this PR as a draft for now until this is properly figured out.

ThanatosGit commented 11 months ago

Iirc this only occurs with empty pkgs which only contains the header without any real file. Dunno why this even exists but if we want to keep the _parsereport for MSR with "real" pkgs, a solution might be to only do it if the file_headers contains at least one element?

ThanatosGit commented 10 months ago

Addressed in #112