search

randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Only align if data section size contains files #112

Closed ThanatosGit closed 11 months ago

ThanatosGit commented 11 months ago

Addresses https://github.com/randovania/mercury-engine-data-structures/pull/108

Is it different for dread? In SR there exists some empty BLA_discardables.pkg. If they have no files in the data section, they also have no 128 byte alignment after the header.

duncathan commented 11 months ago

if you're unsure, add a test that rebuilds and compares every pak to make sure everything passes

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2fb3157) 73.94% compared to head (bb0a046) 73.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## ========================================== + Coverage 73.94% 73.95% +0.01% ========================================== Files 61 61 Lines 3116 3118 +2 ========================================== + Hits 2304 2306 +2 Misses 812 812 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ThanatosGit commented 11 months ago

I don't even know if dread has empty packages but I added changed a test for dread.