search

randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Build vanilla PKGs in SR #117

Closed ThanatosGit closed 6 months ago

ThanatosGit commented 10 months ago

This is the code which can parse and rebuild all pkg files except 11 files. The only problem is the end of the file. Always end with 0 padding at the end of the file except for MSCU MTXT CUT which adds padding to align to 4 bytes.

The wrong_build_sr case in the test is written in a weird way on purpose. It proofes that, of course, the length field is wrong but besides that it's only the ending which is wrong.

Don't know if it should merged 🤷‍♂️

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.19%. Comparing base (69ddf9d) to head (1019948). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #117 +/- ## ========================================== + Coverage 74.02% 74.19% +0.16% ========================================== Files 62 62 Lines 3142 3154 +12 ========================================== + Hits 2326 2340 +14 + Misses 816 814 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ThanatosGit commented 9 months ago

As I have still no idea how I could ever find out the random padding at the end of the file, I would like to merge that post MSR stable. Should I clean up anything here?