randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Add `BorderType` enum to bmsmsd #139

Closed dyceron closed 6 months ago

dyceron commented 6 months ago

Adds an enum to BorderType in the bmsmsd. It's kinda weird and a lot, but it covers all of the tile borders.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.14%. Comparing base (71851d0) to head (2802c6a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #139 +/- ## ======================================= Coverage 74.13% 74.14% ======================================= Files 63 63 Lines 3155 3156 +1 ======================================= + Hits 2339 2340 +1 Misses 816 816 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dyceron commented 6 months ago

this should be a FlagsEnum with just 8 entries (4 normal edges, 4 hidden edges)

You mean instead of the big enum? Idk what that is.

duncathan commented 6 months ago

https://construct.readthedocs.io/en/latest/api/mappings.html

dyceron commented 6 months ago

I sorta understand but what to map the enum values to is confusing

duncathan commented 6 months ago

the values you have for 1, 2, 4, 8, 16, 32, 64, and 128