search

randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

added dread v2.1.0 resources to json #211

Closed steven11sjf closed 2 months ago

steven11sjf commented 3 months ago

Resolves an issue where v2.1.0 resources were always added to custom_names.json when it was exported.

Tested that this does not affect exporting or playing either v1.0.0 or v2.1.0

image

steven11sjf commented 2 months ago

just pushed a bunch of changes btw. seems like there was either an error in our reflection data or a new DisplayObject format, some of the 2.1.0 ones fail.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.47%. Comparing base (c7b1d2b) to head (aed2b21). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================== + Coverage 76.24% 76.47% +0.22% ========================================== Files 76 76 Lines 3528 3528 ========================================== + Hits 2690 2698 +8 + Misses 838 830 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.