randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Small optimizations #55

Closed henriquegemignani closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.48% :tada:

Comparison is base (3a708a1) 65.76% compared to head (a27a317) 66.24%.

:exclamation: Current head a27a317 differs from pull request most recent head f96aa7c. Consider uploading reports for the commit f96aa7c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================== + Coverage 65.76% 66.24% +0.48% ========================================== Files 54 54 Lines 2357 2355 -2 ========================================== + Hits 1550 1560 +10 + Misses 807 795 -12 ``` | [Files Changed](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania) | Coverage Δ | | |---|---|---| | [...ry\_engine\_data\_structures/formats/base\_resource.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2Jhc2VfcmVzb3VyY2UucHk=) | `93.33% <75.00%> (-2.97%)` | :arrow_down: | | [src/mercury\_engine\_data\_structures/formats/brsa.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2Jyc2EucHk=) | `77.77% <75.00%> (+2.77%)` | :arrow_up: | | [src/mercury\_engine\_data\_structures/game\_check.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9nYW1lX2NoZWNrLnB5) | `60.29% <90.00%> (-3.50%)` | :arrow_down: | | [...mercury\_engine\_data\_structures/file\_tree\_editor.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9maWxlX3RyZWVfZWRpdG9yLnB5) | `47.93% <100.00%> (ø)` | | | [...rc/mercury\_engine\_data\_structures/formats/brfld.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2JyZmxkLnB5) | `48.00% <100.00%> (+2.16%)` | :arrow_up: | | [src/mercury\_engine\_data\_structures/formats/pkg.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL3BrZy5weQ==) | `77.67% <100.00%> (+16.31%)` | :arrow_up: | | [src/mercury\_engine\_data\_structures/formats/toc.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL3RvYy5weQ==) | `76.66% <100.00%> (+0.80%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/55/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.