Prep for SR editor

[henriquegemignani]

Be ware that type_lib.py is weird and tools/create_class_definitions.py does weird stuff to it in order to be able to use it before the mercury_engine_data_structures package is importable.

I think your changes in general make it very incompatible with it

[duncathan]

Be ware that type_lib.py is weird and tools/create_class_definitions.py does weird stuff to it in order to be able to use it before the mercury_engine_data_structures package is importable.

I think your changes in general make it very incompatible with it

which raises solution #3: codegen separate type_lib files for MSR and dread 🙃

[codecov[bot]]

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.04% :warning:

Comparison is base (d540e1f) 66.27% compared to head (88c62f1) 66.23%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== - Coverage 66.27% 66.23% -0.04% ========================================== Files 54 55 +1 Lines 2357 2381 +24 ========================================== + Hits 1562 1577 +15 - Misses 795 804 +9 ``` | [Files Changed](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania) | Coverage Δ | | |---|---|---| | [...rcury\_engine\_data\_structures/samus\_returns\_data.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9zYW11c19yZXR1cm5zX2RhdGEucHk=) | `72.97% <0.00%> (-4.17%)` | :arrow_down: | | [...rc/mercury\_engine\_data\_structures/formats/bmsld.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2Jtc2xkLnB5) | `70.83% <33.33%> (-22.50%)` | :arrow_down: | | [src/mercury\_engine\_data\_structures/type\_lib.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy90eXBlX2xpYi5weQ==) | `85.64% <63.04%> (+0.14%)` | :arrow_up: | | [...rcury\_engine\_data\_structures/type\_lib\_instances.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy90eXBlX2xpYl9pbnN0YW5jZXMucHk=) | `88.88% <88.88%> (ø)` | | | [...rc/mercury\_engine\_data\_structures/formats/bmsad.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2Jtc2FkLnB5) | `98.00% <100.00%> (+0.04%)` | :arrow_up: | | [...\_engine\_data\_structures/formats/standard\_format.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL3N0YW5kYXJkX2Zvcm1hdC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ThanatosGit]

bing

[dyceron]

Is this good to go?

[ThanatosGit]

Is this good to go?

Not very familiar with meds code so I don't want to dismiss dark's review but afaik I addressed everything.

[duncathan]

yeah I approved but would like dark to re-review as well since his review was out of scope for mii