randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Add support for BMTUN #80

Closed ThanatosGit closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% :tada:

Comparison is base (f426b8f) 73.11% compared to head (c52feaf) 73.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ========================================== + Coverage 73.11% 73.25% +0.14% ========================================== Files 56 57 +1 Lines 3028 3044 +16 ========================================== + Hits 2214 2230 +16 Misses 814 814 ``` | [Files Changed](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania) | Coverage Δ | | |---|---|---| | [...mercury\_engine\_data\_structures/formats/\_\_init\_\_.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [...rc/mercury\_engine\_data\_structures/formats/bmtun.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2JtdHVuLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ThanatosGit commented 1 year ago

Actually...should I keep "remaining" / construct.Peek(construct.GreedyBytes), or remove it? There is nothing in the remaining bytes which is good but dont' know if we keep it there for "safety".

henriquegemignani commented 1 year ago

Define "which is good"? Is the remaining data just padding that got accidentally included in the file itself? Or is data we don't need for our purposes?

ThanatosGit commented 1 year ago

Oops, I meant there is nothing in the remaining bytes, so it has zero length and zero bytes in it, which is a good thing if you parse files.

henriquegemignani commented 1 year ago

Then replace it with a Terminated.

ThanatosGit commented 1 year ago

Then replace it with a Terminated.

done