randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Add actors sorted by CRC in Bmsld entity groups #88

Closed ThanatosGit closed 1 year ago

ThanatosGit commented 1 year ago

I hope that we finally figured it out: The "magic" sorting of the actors is by their crc32 value, so MEDS should take care of that and provide the helper functions. (btw: I'm open for a more efficient way to keep the list sorted)

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (10e24a2) 73.45% compared to head (8cf1ed1) 73.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #88 +/- ## ========================================== + Coverage 73.45% 73.70% +0.25% ========================================== Files 58 58 Lines 3066 3073 +7 ========================================== + Hits 2252 2265 +13 + Misses 814 808 -6 ``` | [Files](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania) | Coverage Δ | | |---|---|---| | [...rc/mercury\_engine\_data\_structures/formats/bmsld.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2Jtc2xkLnB5) | `96.87% <100.00%> (+0.38%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/88/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.