randovania / mercury-engine-data-structures

Construct type definitions for Mercury Engine.
MIT License
2 stars 11 forks source link

Add support for BMSMSD #91

Closed ThanatosGit closed 1 year ago

ThanatosGit commented 1 year ago

Oh look, a MEDS change for MSR.

Adds support for the minimap files. unk1 and unk2 are always 800.0 in the files I looked at. Guess we can ignore it. No clue about unk3, unk4 unk5. Maybe some sort of type. Guess DCR finds it out when playing around with it 😛

I thought that x_tiles and y_tiles in the header part defines the dimension in tiles, which was matching really good (and still kinda does)...until I found a save station which uses a value one greater than defined. But it's still my best guess.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87ab147) 73.60% compared to head (b91e0ce) 73.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## ========================================== + Coverage 73.60% 73.72% +0.11% ========================================== Files 58 59 +1 Lines 3073 3086 +13 ========================================== + Hits 2262 2275 +13 Misses 811 811 ``` | [Files](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania) | Coverage Δ | | |---|---|---| | [...mercury\_engine\_data\_structures/formats/\_\_init\_\_.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [...c/mercury\_engine\_data\_structures/formats/bmsmsd.py](https://app.codecov.io/gh/randovania/mercury-engine-data-structures/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=randovania#diff-c3JjL21lcmN1cnlfZW5naW5lX2RhdGFfc3RydWN0dXJlcy9mb3JtYXRzL2Jtc21zZC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.