randovania / open-prime-rando

Open Source randomizer patcher for Metroid Prime 2 and eventually 3.
GNU General Public License v3.0
2 stars 7 forks source link

Minor improvements to asset_id_files, let it kinda run for PAL #56

Closed henriquegemignani closed 1 year ago

henriquegemignani commented 1 year ago

But not really because FrontEnd has a different asset id. 😢

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (bf59be5) 76.57% compared to head (588a0e8) 76.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #56 +/- ## ======================================= Coverage 76.57% 76.57% ======================================= Files 27 27 Lines 1157 1157 ======================================= Hits 886 886 Misses 271 271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

henriquegemignani commented 1 year ago

Changed to skip entirely creating files for FrontEnd and the Multiplayer paks.

Whenever we change FrontEnd, we can handle that directly since it has entirely different ids (and will need to check if the areas are very different or not?!)