search

randovania / open-prime-rando

Open Source randomizer patcher for Metroid Prime 2 and eventually 3.
GNU General Public License v3.0
2 stars 7 forks source link

Add Hudmemo's to Dark Oasis and Hive Chamber A #92

Closed JeffGainsNGames closed 2 months ago

JeffGainsNGames commented 9 months ago

Followed the GFMC example.

Only concern would be the size of the Dark Oasis trigger as you might need to walk around a bit for it. Could expand the xy dimensions to cover more of the pool.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (72dc6ea) 87.16% compared to head (d19bc00) 87.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## replace-claris-patcher #92 +/- ## ========================================================== + Coverage 87.16% 87.31% +0.14% ========================================================== Files 39 39 Lines 1714 1734 +20 ========================================================== + Hits 1494 1514 +20 Misses 220 220 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Miepee commented 2 months ago

Why was this PR closed? was this already integrated in #101 ?