Improve crumble block removal patches

randovania / open-samus-returns-rando

Randomizer patcher for Metroid: Samus Returns

GNU General Public License v3.0

5 stars 1 forks source link

Improve crumble block removal patches #465

Closed dyceron closed 9 hours ago

dyceron commented 2 weeks ago

Completely removes the blocks if the configurations are set, instead of having them never respawn.

Surface

Area 1

Fixes #427

ThanatosGit commented 2 weeks ago

But why? That looks like a totally random and unnecessary thing to change from the behaviour it had for months now. How is that improving anything?

Technically, we also named stuff like that remove_... in the schema, which is horrible to migrate
The description in the schema is wrong now
Requires to also change the description in randovania later

dyceron commented 1 week ago

My thought was it's cleaner in game as it actually removes the blocks lolenthe patches say, but I guess it's also a bit overkill for what it's doing. I can close this.

Miepee commented 1 week ago

You could say that maybe it is more intuitive for people who play the rando for the first time and they didnt read the default settings. But default preset starts with scan pulse anyway, and if they don't use it, their fault.

dyceron commented 1 week ago

I'm honestly unsure at this point if this is even worth doing. I'll leave this PR open for the time being.

dyceron commented 9 hours ago

Decided this isn't worth doing at the moment. Could always revisit in the future depending on if we want to make an API to make edits for any block we want.