search

randrescastaneda / joyn

joyn provides a set of tools to analyze the quality of merging (i.e., joining) data frames. It is a JOY to join with joyn
https://randrescastaneda.github.io/joyn/
Other
9 stars 4 forks source link

Workhorse merge #27

Closed zander-prinsloo closed 11 months ago

zander-prinsloo commented 11 months ago

adding the joyn_workhorse function, always doing a full join using collapse backend, unless user-specified many-to-many join, in which case the full cartesian join from merge.data.table is used in the backend. The add_merge_report_column.R script has the function used to add a report column when the merge.data.table is used.

randrescastaneda commented 11 months ago

Hi @zander-prinsloo ,

Thank you for this. a few things

  1. Always create the PR to branch DEV. never to master. We already messed up with the previous PR.
  2. make sure all the tests pass using devtools::check().
  3. You could, either rebase or merge DEV into your branch before you create a PR back into DEV. In this way, your branch has the most recent developments in DEV and you can even solve conflict locally.

So, I am closing this PR because it is into master. Please, let me know if you have any questions. Thanks.