This PR implements the refactor in joyn::joyn() and also the first draft of joyn::merge() that should work in replacement of base::merge() or data.table::merge(). Several things to keep in mind
The merge() function is calling joyn() but it has not been tested because I am waiting for you to finish the workhorse
I moved the current tests of joyn::merge() to joyn::joyn(), so joyn::merge() has no unit test for now.
I added the suffixes, following data.table, so they need to be implemented in joyn
allow.cartesian needs to be implemented
no.dups needs to be implemented
increased version to 0.1.4.9002
I think this is all for now.
The Github tests won't pass with this PR, but I created it for you to start from here if you want to. Also, I won't do anything else in this branch. Any new feature will have its own branch, starting from here.
Hi @zander-prinsloo ,
This PR implements the refactor in
joyn::joyn()and also the first draft ofjoyn::merge()that should work in replacement ofbase::merge()ordata.table::merge(). Several things to keep in mindmerge()function is callingjoyn()but it has not been tested because I am waiting for you to finish the workhorsejoyn::merge()tojoyn::joyn(), sojoyn::merge()has no unit test for now.suffixes, followingdata.table, so they need to be implemented injoynallow.cartesianneeds to be implementedno.dupsneeds to be implementedI think this is all for now. The Github tests won't pass with this PR, but I created it for you to start from here if you want to. Also, I won't do anything else in this branch. Any new feature will have its own branch, starting from here.