search

randy3k / AutomaticPackageReloader

Automatically reload submodules while developing a Sublime Text package.
MIT License
38 stars 13 forks source link

[TODO] fix #16 #17

Closed timotheecour closed 6 years ago

timotheecour commented 6 years ago
randy3k commented 6 years ago

could you explain why it is necessary?

timotheecour commented 6 years ago

the current logic didn't work in my setting, see https://github.com/randy3k/AutomaticPackageReloader/issues/16

'/Users/timothee/Library/Application Support/Sublime Text 3/Packages' is a symlink to /Users/timothee/git_clone/sublime_packages (because I don't like spaces in paths)

and some packages in /Users/timothee/git_clone/sublime_packages are symlinks (because of how I organize my files), eg:

ls /Users/timothee/git_clone/sublime_packages AutomaticPackageReloader -> /Users/timothee/git_clone//AutomaticPackageReloader/

try it for yourself, the code didn't work with that setup

randy3k commented 6 years ago

I am pretty sure your code will break some windows machines without the casedpath function.

randy3k commented 6 years ago

Well, I might be wrong, casedpath may be necessary now. Need more testing.

timotheecour commented 6 years ago

PTAL

randy3k commented 5 years ago

@timotheecour

This breaks the detection of the package if the package folder is listed in the sidebar but no file is opened.

I have reverted this PR instead of fixing it. Please resubmit a PR for the fix for your issue at your will.