randy3k / AutomaticPackageReloader

Automatically reload submodules while developing a Sublime Text package.
MIT License
38 stars 13 forks source link

Fix attribute error due to Package Control method renaming #42

Closed phhuyhoang closed 10 months ago

phhuyhoang commented 11 months ago

Package Control has just released version 4.0.0 a few days ago, including changes to some methods that this package depends on. If you reload a package, this error will occur:

File "/home/phhuyhoang/.config/sublime-text-3/Packages/AutomaticPackageReloader/package_reloader.py", line 117, in run_async
    package, dependencies=dependencies, extra_modules=extra_modules, verbose=verbose)
  File "/home/phhuyhoang/.config/sublime-text-3/Packages/AutomaticPackageReloader/reloader/reloader.py", line 80, in reload_package
    for parent in resolve_parents(package):
  File "/home/phhuyhoang/.config/sublime-text-3/Packages/AutomaticPackageReloader/reloader/resolver.py", line 14, in resolve_parents
    everything = manager.list_packages() + manager.list_dependencies()
AttributeError: 'PackageManager' object has no attribute 'list_dependencies'

This PR fixes that bug. Anyway, this is a great package that I've been using for two years. Love it.

deathaxe commented 11 months ago

Fixes #41

randy3k commented 10 months ago

Sorry for the late reply, can you check if package control is version 4.0? I don't have everybody has migrated to PC 4.0 yet.

randy3k commented 10 months ago

Actually, let's merge it as is. I think most users should migrate to PC 4.0 anyway.