randy3k / Terminus

Bring a real terminal to Sublime Text
https://packagecontrol.io/packages/Terminus
MIT License
1.39k stars 81 forks source link

terminus background color and theme changes are not reflecting #230

Open roguexray007 opened 4 years ago

roguexray007 commented 4 years ago

os : mac os sublime text version : 3 theme: guna

Screenshot 2020-07-16 at 5 04 44 PM

changed "theme": "one of default provided by terminus" in settings, no change happens

roguexray007 commented 4 years ago

no colors as in issue https://github.com/randy3k/Terminus/issues/220

heitorsilva commented 4 years ago

Happens to me as well... I'm on MacOS Catalina, with Sublime Text 3, and my default shell is ZShell, with oh-my-zsh being loaded by default.

If I change the theme, nothing changes on terminus...

randy3k commented 4 years ago

Did you enable 256 color?

heitorsilva commented 4 years ago

It doesn't matter if 256 color is ON or OFF, it doesn't work either way. Example of settings:

{
    "256color": true,
    "default_config":
    {
        "linux": null,
        "osx": "Zsh",
        "windows": "Command Prompt"
    },
    "theme": "broadcast"
}

or

{
    "256color": false,
    "default_config":
    {
        "linux": null,
        "osx": "Zsh",
        "windows": "Command Prompt"
    },
    "theme": "broadcast"
}

none work...

is there a chance of oh-my-zsh being in the way of Terminus, to apply the right theme?

my Terminus always looks like this:

Screenshot 2020-07-17 at 15 39 35
randy3k commented 4 years ago

How about changing the term setting to xterm-256color?

heitorsilva commented 4 years ago

Nope... no changes. I tried ansi also, but it doesn't work.

Screenshot 2020-07-17 at 17 53 50

the console in the background is Terminus, and the forefront is Terminal. They're having the same color scheme.

randy3k commented 4 years ago

It seems that the theme has been applied. What is your issue there?

heitorsilva commented 4 years ago

No, the theme doesn't change... doesn't matter what I select as theme, it always stays with the appearance of the screenshot I showed you.

randy3k commented 4 years ago

The theme only controls ansi colors 0 to 16. Are your prompt etc using 256 color sequences?

heitorsilva commented 4 years ago

As you can see in the screenshot, the terminal is configured with xterm-256colour.

I tried with ansi also, but had no effect.

randy3k commented 4 years ago

I am lost, why are you showing macOS terminal? I meant you should change the term setting in Terminus preference to xterm-256colour.

heitorsilva commented 4 years ago

In here https://github.com/randy3k/Terminus/issues/230#issuecomment-660112835 I showed you my Terminus configs, and doesn't matter if I have 256color true or false.

When you said about term setting to xterm-256color (https://github.com/randy3k/Terminus/issues/230#issuecomment-660174734), I thought you were talking about the MacOS terminal, and not Terminus.

but now I realised you were talking about "unix_term": "xterm-256color".

I changed that, and still doesn't work... now my settings are like this:

{
    "256color": true,
    "default_config":
    {
        "linux": null,
        "osx": "Zsh",
        "windows": "Command Prompt"
    },
    "theme": "atom",
    "unix_term": "xterm-256color"
}

Do I have to quit Sublime and open again to make them work after saving the preferences file? Because I'm not quitting Sublime when I change the settings... should I?

idbentley commented 4 years ago

fwiw - I was having the same problem, and restarting sublime after each theme change was what I needed to do.

heitorsilva commented 4 years ago

I can also confirm that quitting Sublime and reopening makes the theme be applied, like @idbentley said (thanks).

Problem solved for me... 🤘 🎉

randy3k commented 4 years ago

Normally it doesn't require a restart to change theme. Not sure why.

thezimmee commented 4 years ago

I'm experiencing the same issue. I can successfully apply non-user themes (after restarting Sublime), but my user theme does not apply colors from user_theme_colors, which is what I expected. I do have 256color set to true and unix_term is set to xterm-256color, though I have tried with both of those reset to their defaults as well.

@heitorsilva Are you able to apply a user theme?

Anybody know how I can apply my user theme?

P.S. @randy3k Thank you so much for this package! I recently started using it, and it has quickly become one of my favorite Sublime packages. Many, many thanks.

heitorsilva commented 4 years ago

@thezimmee no, I'm not.

I'm using the ir-black preset.

randy3k commented 4 years ago

@thezimmee Did you set theme to user?

thezimmee commented 4 years ago

@randy3k Yes.

randy3k commented 4 years ago

Could you try to regenerate the theme from the command palatte?

thezimmee commented 4 years ago

You mean Terminus Utilities: Generate User Theme? I just tried that, then restarted Sublime, still no luck...

neunato commented 4 years ago

Normally it doesn't require a restart to change theme. Not sure why.

I've always had to restart for theme changes to take effect.

Penguin98kStudio commented 3 years ago

Normally it doesn't require a restart to change theme. Not sure why.

Same thing happens to me on my Desktop, maybe Its related to something in sublime because on my laptop (slightly older sublime or plugin) the theme change used to be instantenous. I could see changes while scrolling though the theme list

I am a windows user.

Morphy-Kun commented 3 years ago

It happens to me as well. I need to restart sublime every time I select a new terminus theme. I was wondering if there was a place where I could see screenshots of how all the themes are going to look like. There are so many themes it gets kinda tedious while you are trying them out, not that I'm not grateful that there are so many choices ( ๑♡⌓♡๑)/ Or maybe if there was some option or command to reload terminus without needing to restart sublime, that'd nice too.