search

randy3k / Terminus

Bring a real terminal to Sublime Text
https://packagecontrol.io/packages/Terminus
MIT License
1.39k stars 81 forks source link

Initial terminal output messed up. #236

Closed deathaxe closed 4 years ago

deathaxe commented 4 years ago

When opening a new terminus pane, the initial output of the interpreter is messed up. It looks as the number of columns is heavily limited.

Powershell

grafik

Bash

grafik

After hitting enter or simply run the first command, the with is ok.

I guess it is caused by or at least related with https://github.com/randy3k/Terminus/pull/215/files

randy3k commented 4 years ago

I don't think it's related to that PR. I have been seeing similar issue for sine time. It seems a synchronisation issue of the renderer after a size change and it does not always occur.

deathaxe commented 4 years ago

The window size doesn't change when starting the terminal and I can reproduce 100% at each startup with each interpreter. I've never seen that before.

That said, I am not sure whether it is related with that PR, but why is the width limited to 20 characters, which is exactly the default value of min_columns setting?

The good news is I can workaround that bug by setting "min_columns": 80.

randy3k commented 4 years ago

Ah, you may be right.

There is a fallback to 80 if the detected width is 1 (the value that we get for a new panel). However, the PR sets a minimum to 20 instead of 1 and it breaks the fallback.

randy3k commented 4 years ago

71e5acc should fix it. Please reopen if it doesn't.

deathaxe commented 4 years ago

Thanks.