randy3k / Terminus

Bring a real terminal to Sublime Text
https://packagecontrol.io/packages/Terminus
MIT License
1.38k stars 84 forks source link

Color inconsistencies in last release #308

Closed simov closed 2 years ago

simov commented 2 years ago

Recently I restarted Sublime and it seems I got the new version of Terminus. However, I'm noticing some color inconsistencies between my default Bash terminal and Terminus:

terminus-colors

left: Bash, right: Terminus

I have been using a custom theme ever since, but I noticed that the theme config now have to use color names instead of indexes, but even with that change Terminus is picking only the background and the foreground colors and it does not react to any other color change. Also not sure where the bold style went and how to bring it back.

{
  "theme": "user",
  "user_theme_colors": {
    "background": "#000000",
    "foreground": "#f8f8f2",
    // "caret": "white",
    // "block_caret": "white",
    // "selection": "#444444",
    // "selection_foreground": "#ffffff"

    "black": "#555753",
    "red": "#EF2929",
    "green": "#8AE234",
    // "brown": "#cdcd00",
    "blue": "#729FCF",
    "magenta": "#AD7FA8",
    "cyan": "#34E2E2",
    // "white": "#e5e5e5",

    // "light_black": "#7f7f7f",
    // "light_red": "#ff0000",
    // "light_green": "#00ff00",
    // "light_brown": "#ffff00",
    // "light_blue": "#5c5cff",
    // "light_magenta": "#ff00ff",
    // "light_cyan": "#00ffff",
    // "light_white": "#ffffff"
  },
  "view_settings": {
    "rulers": [],
    "font_face": "Monospace",
    "font_size": 10.5,
  },
}

I'm using Ubuntu 18.04 and ST4

simov commented 2 years ago

This is how adaptive looks like on my end:

This one seems completely off

terminus-adaptive

This is the classic one:

This one picks the cyan and the green correctly, but the blue is dark blue

terminus-classic

This one is using my custom user theme:

This one only picks the background from my custom theme, none of the ANSI codes work

terminus-user

And this is how my terminal look like:

The bold text was not detected at all in terminus

terminal

Before latest update my terminal and terminus looked identical using this theme:

{
  "theme": "user",
  "user_theme_colors": {
    "background": "#000000",
    "foreground": "#f8f8f2",
    // "caret": "white",
    // "block_caret": "white",
    // "selection": "#444444",
    // "selection_foreground": "#ffffff"

    "00": "#555753", // black
    "01": "#EF2929", // red
    "02": "#8AE234", // green
    // "03": "#cdcd00", // brown
    "04": "#729FCF", // blue
    "05": "#AD7FA8", // magenta
    "06": "#34E2E2", // cyan
    // "07": "#e5e5e5", // white

    // "08": "#7f7f7f", // light_black
    // "09": "#ff0000", // light_red
    // "10": "#00ff00", // light_green
    // "11": "#ffff00", // light_brown
    // "12": "#5c5cff", // light_blue
    // "13": "#ff00ff", // light_magenta
    // "14": "#00ffff", // light_cyan
    // "15": "#ffffff" // light_white
  },
  "view_settings": {
    "rulers": [],
    "font_face": "Monospace",
    "font_size": 10.5,
  }
}
randy3k commented 2 years ago

Looks like you didn't define the light color. The recent version of Terminus has a new setting to brighten bold text.

randy3k commented 2 years ago

I would suggest you to dup all the normal colors to light colors if you don’t need the feature.

simov commented 2 years ago

Ok, that fixed the color issues: terminus-light

Compared to: terminal-light

But the bold style is nowhere to be seen. Is there anything else I can do to bring it back?

randy3k commented 2 years ago

The bold style is not supported, nor it was never supported. The new setting is a workaround for the bold text.

simov commented 2 years ago

I'm using Terminus since around March 2020 and up until v0.3.18 my Bash terminal and Terminus looked identical and bold text was definitely rendered correctly.

I'm using GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu) on Ubuntu 18.04 on ST3 at that time and now using ST4.

Again with the above setup, and up until v0.3.18, bold text was rendered correctly and the color was also brightened up correctly as well, because I was not specifying the lighter colors explicitly in my user theme.

As far as I understand the new brighten_bold_text option in v0.3.19 was introduced to simulate what I have in Bash here (the checkbox at the bottom):

Screenshot from 2021-08-23 09-56-54

but that option has no effect whatsoever with my setup above. It simply doesn't work on any theme preset: classic, adaptive or the user one, and again that's besides the fact that the bold text is no longer rendered as bold text as it was in v0.3.18.

randy3k commented 2 years ago

bold text was definitely rendered correctly.

It is impossible. Bold text was never supported in Terminus.

bold text was rendered correctly and the color was also brightened up correctly as well, because I was not specifying the lighter colors explicitly in my user theme.

Without the lighter colors in the settings, it is using the colors from the "classic" theme. I'll be surprised to learn that the colors are the same as those of your terminal.

simov commented 2 years ago

Ok, that might be my mistake about the bold style. It's probably my mind playing tricks on me, which is funny because I'm looking at that same terminal every single day. In any case, colors look identical with my terminal now so that works for me :+1: