search

randylien / generator-react-gulp-browserify

A Yeoman Generator for facebook's React library. It includes gulp, browserify, livereload and famous official Twitter bootstrap Sass version
422 stars 60 forks source link

bower_components/ missing from .gitignore #46

Open mattclaw opened 9 years ago

mattclaw commented 9 years ago

Perhaps this is a matter of preference?

Please see PR #47

mattclaw commented 9 years ago

Looks like there are some good arguments for either side.

randylien commented 9 years ago

If we all only use NPM to manage our packages, we don't need Bower anymore. But I know some packages you can't find from NPM. Try to highlight this part in README.

codeofsumit commented 8 years ago

/bower_components/ is inside .gitignore, but it should be /app/bower_components/

mattclaw commented 8 years ago

.gitignore works by pattern matching, so you don't need to give the full relative path to your directory or file. The level of specificity is another matter of preference, but I would argue one reason to be less specific is to make it easy for someone to change the path to bower_components without having to touch .gitignore. Of course, you could then argue that a user who is sufficiently advanced enough to customize .bowerrc can also handle modifying .gitignore or might also choose a name that doesn't match bower_components.