search

randylien / generator-react-gulp-browserify

A Yeoman Generator for facebook's React library. It includes gulp, browserify, livereload and famous official Twitter bootstrap Sass version
422 stars 60 forks source link

Other prerequisites needed #69

Open richtong opened 8 years ago

richtong commented 8 years ago

I'm not sure how active this project is, but some notes on installation:

  1. Bower is required for this to work as is gulp, so you should add to the README.md and then you need npm install -g bower gulp
  2. Also is reactify being used anymore, I see that the current build seems to install babelify instead. Is the README.md out of date?
  3. Also jest seems to be using react-tools to process the javascript and react-tools version is linked to a deprecated version. Seems like jest should use the same transformer as the main system. I was wondering why you did it this way? I thought the proper way was to use babel-jest and link it that way per https://github.com/facebook/jest and then you need to change the package.json to point to it a la http://stackoverflow.com/questions/28870296/how-to-use-jest-with-webpack so you need to change the "scriptPreProcessor" : "<root-dir>/node_modules/babel-jest"
richtong commented 8 years ago

Thanks for integrating the pull request. I'll add README.md change if there is another one :-)