Plus4: order of cursor keys is wrong

randyrossi / bmc64

A bare metal Commodore 64 emulator for the Raspberry Pi with true 50hz/60hz smooth scrolling, low input latency and better audio/video sync.

GNU General Public License v3.0

479 stars 56 forks source link

Closed SvOlli closed 4 years ago

SvOlli commented 4 years ago

Using the GPIO keyboard adapter, in Plus4 mode the keys are in the following order: down up left right But they should be left right up down

The attached patch fixes that. I hope the fix gets in the code before the release of 3.6-stable.

rhester72 commented 4 years ago

Wouldn't this affect all keyboard input, whether it's GPIO or USB?

The point: It may help GPIO users, but will it hurt other users?

SvOlli commented 4 years ago

I just double-checked: no.

The array is used at kernel.cpp line 739 only. And that code is obviously only for handling GPIOs.