randyrossi / bmc64

A bare metal Commodore 64 emulator for the Raspberry Pi with true 50hz/60hz smooth scrolling, low input latency and better audio/video sync.
GNU General Public License v3.0
475 stars 56 forks source link

update vice past r37819 #141

Open kiwanowski opened 3 years ago

kiwanowski commented 3 years ago

hello, is it possible to update vice past r37819? I plan to use bmc64 for music composing but for a really long time vice had a filter saturation bug for 8580. It was reported here - https://sourceforge.net/p/vice-emu/bugs/909/ and fixed in r37819

Below is a quick comparison of vice 2.4, vice 3.x before the fix, and vice after the fix:

New Filters Before: https://jansalleine.com/trans/fossil-vice-new-filters.wav

New Filters Current: https://jansalleine.com/trans/fossil-vice-new-filters-r37853.wav

Old Filters: https://jansalleine.com/trans/fossil-vice-old-filters.wav

rhester72 commented 3 years ago

See attached diff that provides the 8580 filter fixes from r37819 (and earlier) made against current bmc64 source.

new8580filter_bmc64_r37819-patch.zip

and the kernel binaries for anyone who can't compile:

[removed, see later comment]

Feedback welcomed!

(Congrats! Pretty sure this was the last 'big' thing from upstream VICE that Randy felt was missing!)

randyrossi commented 3 years ago

Cool. Thanks for putting that together. I should really dedicate some time to putting out another update. I've been obsessed with my latest project though and never seem to find the time.

On Tue, Jan 19, 2021 at 3:00 PM rhester72 notifications@github.com wrote:

See attached diff that provides the fix from r37819 made against current bmc64 source.

new8580filter_bmc64.zip https://github.com/randyrossi/bmc64/files/5838305/new8580filter_bmc64.zip

(Congrats! Pretty sure this was the last 'big' thing from upstream VICE that Randy felt was missing!)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/randyrossi/bmc64/issues/141#issuecomment-763093368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3HKH6RU227TUE2YHKR33S2XQHLANCNFSM4TCBHMJQ .

-- Randy Rossi

rhester72 commented 3 years ago

The below-attached ZIP should now work on all systems (including Pi Zero) and includes paddle support as recently added, the 8580 filter fixes, and the Xbox 360 gamepad button fix.

bmc64_kernels_20210201+8580fix.zip

rhester72 commented 3 years ago

@randyrossi The 8580 filter fix is vetted now, please integrate into git master:

https://github.com/randyrossi/bmc64/files/5839571/new8580filter_bmc64_r37819-patch.zip