randyrossi / bmc64

A bare metal Commodore 64 emulator for the Raspberry Pi with true 50hz/60hz smooth scrolling, low input latency and better audio/video sync.
GNU General Public License v3.0
473 stars 56 forks source link

3.7 Preview - Drive Sound Emulation #183

Closed Eddepad closed 2 years ago

Eddepad commented 3 years ago

There seems to be an issue with the Drive Sound Emulation in 3.7 preview and the latest Master Build (although not with the Master Build from March this year).

After clean install: Enable Drive Sound Emulation (I set this on 500 sound level). Then save settings off course. After that attach a disk and type in the LOAD"$",8 command and then you will hear the sound of the drive. Everything OK.

Then power off the RPI and start it up again. Then attach a disk and type again LOAD"$",8. There is no sound anymore from my speakers. BTW, I have the sound via HDMI connection at my monitor.

Can anyone reproduce this or I am doing something wrong?

rhester72 commented 2 years ago

I can confirm this as well, but I'm not sure of the cause. It seems to affect all emulators.

CemTezcan commented 2 years ago

I have the same problem too.

randyrossi commented 2 years ago

I think I see the problem. Commit

48f9989db98a9592f4a03b416ea9186e890b8edb set the volume to 0 by accident.

I'll put in a fix soon.

On Mon, Aug 2, 2021 at 4:57 AM CemTezcan @.***> wrote:

I have the same problem too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/randyrossi/bmc64/issues/183#issuecomment-890852166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3HKCSBOEEYDKAPNG3SO3T2ZMVZANCNFSM5AEJSDQA .

-- Randy Rossi

randyrossi commented 2 years ago

Can you try the images at https://accentual.com/bmc64/downloads/master/ to see if I fixed the problem with drive sound emulation volume?

On Mon, Aug 2, 2021 at 8:20 AM Randy Rossi @.***> wrote:

I think I see the problem. Commit

48f9989db98a9592f4a03b416ea9186e890b8edb set the volume to 0 by accident.

I'll put in a fix soon.

On Mon, Aug 2, 2021 at 4:57 AM CemTezcan @.***> wrote:

I have the same problem too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/randyrossi/bmc64/issues/183#issuecomment-890852166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3HKCSBOEEYDKAPNG3SO3T2ZMVZANCNFSM5AEJSDQA .

-- Randy Rossi

  • "There are only two things that are hard about computer science; Naming things, Cache Invalidation, and Off-by-one errors."

-- Randy Rossi

Eddepad commented 2 years ago

@randyrossi Thanks, the new Master Build seems to work for now (still have the drive sound).

Can you please check something else? Mode (1) C64/PAL/HDMI/ 50 hz Mode (2) C64/PAL/HDMI/ 50.125 hz

At the option: Video/CRT shader/Mask Type Mode (1) when I select "Trinitron" it is different when in Mode (2), where I have to select "Green/Magenta" to get the trinitron mask.

Thanks for your feedback,

rhester72 commented 2 years ago

@Eddepad I suspect the masks look different because of the very different screen resolution between the two selections. They definitely aren't changing between screen modes. =)

rhester72 commented 2 years ago

@randyrossi This has now been fully confirmed as working and can probably be closed.

Eddepad commented 2 years ago

@Eddepad I suspect the masks look different because of the very different screen resolution between the two selections. They definitely aren't changing between screen modes. =)

Thanks for your reply. If you tested it yourself I must be mistaken :-) Closing issue...