search

randyrossi / bmc64

A bare metal Commodore 64 emulator for the Raspberry Pi with true 50hz/60hz smooth scrolling, low input latency and better audio/video sync.
GNU General Public License v3.0
474 stars 56 forks source link

Update kernel.cpp for C128 extra keys in C128 mode. #240

Open nickgoodmanuk opened 10 months ago

nickgoodmanuk commented 10 months ago

Added my proposed change for the Commodore 128 keyboards extra keys, as discussed in issue 201. This is untested as I was not able build my own kernal.

https://github.com/randyrossi/bmc64/issues/201

randyrossi commented 10 months ago

I will make a build with these changes in and put it up as a test build in a directory on my site. Can you ping me if you don't hear back from me in a couple days? I'm consumed by work right now but I will try to do this so you can test the changes. Then we can merge this in and do a release.

On Tue, Aug 22, 2023 at 6:27 AM Nick Goodman @.***> wrote:

Added my proposed change for the Commodore 128 keyboards extra keys, as discussed in issue 201. This is untested as I was not able build my own kernal.

201 https://github.com/randyrossi/bmc64/issues/201

You can view, comment on, or merge this pull request online at:

https://github.com/randyrossi/bmc64/pull/240 Commit Summary

File Changes

(1 file https://github.com/randyrossi/bmc64/pull/240/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/randyrossi/bmc64/pull/240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3HKCULTZQTPXZSHT2XY3XWSCQNANCNFSM6AAAAAA3ZWBXW4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Randy Rossi

nickgoodmanuk commented 10 months ago

> I will make a build with these changes in and put it up as a test build in a directory on my site. Can you ping me if you don't hear back from me in a couple days? I'm consumed by work right now but I will try to do this so you can test the changes. Then we can merge this in and do a release.

Will do, Thankyou. I know you are very busy, as am I haven't had chance to address it further until now. I appreciate it.

nickgoodmanuk commented 10 months ago

@randyrossi Gentle reminder about a test build. No rush :)

randyrossi commented 10 months ago

Please see the review comments. The change won't work as you expect. There is additional work to do with the gpio lines.

On Thu, Aug 31, 2023 at 4:27 AM Nick Goodman @.***> wrote:

@randyrossi https://github.com/randyrossi Gentle reminder about a test build. No rush :)

— Reply to this email directly, view it on GitHub https://github.com/randyrossi/bmc64/pull/240#issuecomment-1700590579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3HKABJDXTETX2HFXDLBLXYBDGTANCNFSM6AAAAAA3ZWBXW4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Randy Rossi

nickgoodmanuk commented 8 months ago

Changes made to pull request now I have been able to build myself.