randywallace / zabbix-cloudwatch

An external script for getting cloudwatch metrics into Zabbix
MIT License
27 stars 11 forks source link

method get_aws_options always returns region set to us-east-1 #2

Closed paulruiz closed 9 years ago

paulruiz commented 10 years ago

Lack of parentheses in " if options.key?"aws-region" && options['aws-region'] != '' " caused it to always fall through to the else and set region to use-east-1. Pull request adds parens. Tested failure and success on 1.8.7 and 2.0.

dewdo commented 9 years ago

Thanks for this.

randywallace commented 9 years ago

@paulruiz Oh man, I'm so sorry this fell thru the cracks (I get hundreds of emails from github a day.. should probably do something about that..). Merging now.