fig.render() is used several time in a row for st_folium

[BastienGauthier]

I did not succeed in testing locally on my side (not sure how to deal with the _component_func), but I figured that with v0.14 version of st_folium, the main computation time is used with my use case by the "fig.render()" folium function.

This is used twice in the process of the map creation :

• first line in _get_map_string
• first line in _get_siblings

Given these two functions are used only once in the init, would it be possible to mutualize the render only once on folium_map, before calling these to function ? This could improve performance drastically (once again !)

[BastienGauthier]

@randyzwitch or @blackary, by chance, do you have any tutorial on how I can follow so I can test the package locally before any PR ?

[randyzwitch]

(Doing this from phone, sorry for not direct linking)

If you go to the .github directory, you’ll see how we run the tests for each pull request. Basically, you pip install (-e if I’m not mistaken to install globally) then run the tests

[BastienGauthier]

Thanks for the precision ! I had some trouble compiling (tried v18 instead of v16...), but I could made a proposition. I have seen no regression and I a very significative performance improvement. I hope you will like it !