Closed randyzwitch closed 10 months ago
Doesn't look like this is failing because of flaky tests, but because if incorrectly specified literals in the assert statement
Looks like #157 passes the tests, so maybe that should get merged first
I think I'll need to update the tests a bit to support the new code that folium outputs. The frontend tests all pass, so this does in fact resolve the issue of 0.15.0 incompatibility. But, the code that tests the specific js output is now failing because folium has updated the code slightly.
I also do think we should exclude 0.15.0, because otherwise, if someone already has that version of folium installed, and we just say they need >= 0.13, then the solver won't realize it needs to upgrade them to 0.15.1. But, I can do that.
Warning : I think the ",!=0.15.0" in the requirement.txt is on the wrong line (streamlit instead of folium)
Warning : I think the ",!=0.15.0" in the requirement.txt is on the wrong line (streamlit instead of folium)
Good catch @BastienGauthier
If I'm thinking about this correctly @blackary, we don't need to exclude 0.15.0 per se, since the solver should always go to the patch version. Thus, we can keep the requirements much looser.
If you disagree, then make a commit here. Otherwise, we'll put out a new version of streamlit-folium as well.
References #148