search

randyzwitch / streamlit-folium

Streamlit Component for rendering Folium maps
https://folium.streamlit.app/
MIT License
468 stars 176 forks source link

pixelated images when needed #176

Closed rupestre-campos closed 6 months ago

rupestre-campos commented 6 months ago

Added way to ensure image pixelated style because st_folium was not rendering the styles set with folium.ImageOverlay(..., pixelated=True) making images blurrier, which sometimes is not desirable. I had this issue and there was another person on streamlit community forum that also noted this behavior link to post.

I would like to help on this topic with this pull request, so if you guys think this is good for the project I am willing to fulfill any changes that are needed for the merge, and excuse me if I did anything out of pattern, I am new to contributing and willing to learn by doing.

randyzwitch commented 6 months ago

No worries at all, welcome to the project! I'd love for a hundred more of you to show up and really make this package shine.

I'm not a JS person, so will defer to @blackary about whether there are any stylistic issues...otherwise, I'll try to test it out in the next few days and we'll get it merged 🥳

rupestre-campos commented 6 months ago

So nice to see this, thanks for the welcome! It is a great joy to help, just to be clear I am not a javascript expert, so a review would be highly appreciated. If there is a more simplistic, intuitive or aligned with projects patterns way to do it also I would be happy to fix. I just checked some formatting tests have failed to complete and configured to run pre-commit script to check for it on next runs, commited a update with formatting rules applied.

randyzwitch commented 6 months ago

Merged and tagged a new release https://github.com/randyzwitch/streamlit-folium/releases/tag/v0.19.0