ranelpadon / ngram-type

Touch typing trainer using N-grams as data source, with options to customize the auto-generated lessons and specify the minimum typing performance needed. There are sound/color effects as well.
208 stars 40 forks source link

Pangram/Custom #7

Closed nkabbara closed 2 years ago

nkabbara commented 2 years ago

Hello!

When I click on the custom link, nothing is happening. Am I supposed to get a dialogue to input text? I tried on chrome and firefox.

ranelpadon commented 2 years ago

Yeah, I noticed it also recently, but I thought it was just due to my browser caching. I think it was broken at some point, and I just didn't notice. I'll fix it asap (most likely this weekend). Thanks for reporting the issue.

nkabbara commented 2 years ago

Thank you very much!

While using keybr.com I noticed a couple of bigrams (er and re) that are problematic for me. I swap them. ie. Instead of typing er, I type re and vice versa. But mostly happens in those bigrams, not when e and r are with different letters.

So my plan was to feed these into custom and have it train me :)

On Wed, Jan 5, 2022 at 1:03 AM ranelpadon @.***> wrote:

Yeah, I noticed it also recently, but I thought it was just due to my browser caching. I think it was broken at some point, and I just didn't notice. I'll fix it asap (most likely this weekend). Thanks for reporting the issue.

— Reply to this email directly, view it on GitHub https://github.com/ranelpadon/ngram-type/issues/7#issuecomment-1005432057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHY6PS7V37KUQHDZGVOXDUUPUNPANCNFSM5LI7GCUA . You are receiving this because you authored the thread.Message ID: @.***>

ranelpadon commented 2 years ago

@nkabbara Fixed it now as per https://github.com/ranelpadon/ngram-type/commit/311d5e2595f4133149d7acf6ffc37d10a4a9dd72.

Apparently, I used Bootstrap 4 before using this link (which always point to latest version): https://bootswatch.com/_vendor/bootstrap/dist/js/bootstrap.bundle.min.js

But now it points to Bootstrap 5! So, just pointed to correct/previous version: https://bootswatch.com/4/_vendor/bootstrap/dist/js/bootstrap.bundle.min.js

That's why I'm puzzled also why it's not working at some point even though I don't have code changes related to it.

Live screenshot:

Screen Shot 2022-01-07 at 5 24 25 PM

Please verify. Cheers

nkabbara commented 2 years ago

Thank you sir! Verified and works great!

On Fri, Jan 7, 2022 at 3:30 AM ranelpadon @.***> wrote:

@nkabbara https://github.com/nkabbara Fixed it now as per 311d5e2 https://github.com/ranelpadon/ngram-type/commit/311d5e2595f4133149d7acf6ffc37d10a4a9dd72 .

Apparently, I used Bootstrap 4 before using this link (which always point to latest version): https://bootswatch.com/_vendor/bootstrap/dist/js/bootstrap.bundle.min.js

But now it points to Bootstrap 5! So, just pointed to correct/previous version: https://bootswatch.com/4/_vendor/bootstrap/dist/js/bootstrap.bundle.min.js

That's why I'm puzzled also why it's not working at some point even though I don't have code changes related to it.

Live screenshot:

[image: Screen Shot 2022-01-07 at 5 24 25 PM] https://user-images.githubusercontent.com/4292088/148522553-b26396ed-7367-40f8-ae96-e6e4ea1c5336.png

Please verify. Cheers

— Reply to this email directly, view it on GitHub https://github.com/ranelpadon/ngram-type/issues/7#issuecomment-1007261331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHY6IFNLBO4B2DFWWXHI3UU2XDFANCNFSM5LI7GCUA . You are receiving this because you were mentioned.Message ID: @.***>

ranelpadon commented 2 years ago

Nice! Will close this issue now. Thanks :)