ranfdev / Geopard

Colorful, adaptive gemini browser
https://ranfdev.com/projects/Geopard/
GNU General Public License v3.0
151 stars 10 forks source link

fix validate-appdata test #101

Closed iFoundSilentHouse closed 5 months ago

iFoundSilentHouse commented 6 months ago

closes https://github.com/ranfdev/Geopard/issues/100

iFoundSilentHouse commented 6 months ago

Like this?


diff --git a/data/com.ranfdev.Geopard.metainfo.xml.in.in b/data/com.ranfdev.Geopard.metainfo.xml.in.in
index d2ffa1f..e27ffb2 100644
--- a/data/com.ranfdev.Geopard.metainfo.xml.in.in
+++ b/data/com.ranfdev.Geopard.metainfo.xml.in.in
@@ -88,10 +88,12 @@
     </release>
     <release version="1.1.0" date="2022-05-19">
       <description>
-        <p>Improved design, with completely new pages for downloads, input requests, external links, errors</p>
-        <p>Added more spacing between links to make them easier to click on small screens</p>
-        <p>Added zoom functionality, via shortcuts or directly from the popover menu</p>
-        <p>Streaming button (alpha) for some audio/video file types</p>
+        <p>
+          <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
+          <li>Added more spacing between links to make them easier to click on small screens</li>
+          <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
+          <li>Streaming button (alpha) for some audio/video file types</li>
+        </p>
       </description>
     </release>
     <release version="1.0.1" date="2022-05-07">
'''
iFoundSilentHouse commented 6 months ago

Test failed that way with <p> is too short

iFoundSilentHouse commented 6 months ago
diff --git a/data/com.ranfdev.Geopard.metainfo.xml.in.in b/data/com.ranfdev.Geopard.metainfo.xml.in.in
index f35c019..8f58603 100644
--- a/data/com.ranfdev.Geopard.metainfo.xml.in.in
+++ b/data/com.ranfdev.Geopard.metainfo.xml.in.in
@@ -88,12 +88,10 @@
     </release>
     <release version="1.1.0" date="2022-05-19">
       <description>
-        <ul>
-          <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
-          <li>Added more spacing between links to make them easier to click on small screens</li>
-          <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
-          <li>Streaming button (alpha) for some audio/video file types</li>
-        </ul>
+        <p><li>Improved design, with completely new pages for downloads, input requests, external links, errors</li></p>
+        <p><li>Added more spacing between links to make them easier to click on small screens</li></p>
+        <p><li>Added zoom functionality, via shortcuts or directly from the popover menu</li></p>
+        <p><li>Streaming button (alpha) for some audio/video file types</li></p>
       </description>
     </release>
     <release version="1.0.1" date="2022-05-07">

Failed with same error

tfuxu commented 6 months ago

No, you should put it like that:

<p>
    <ul>
        <li>Item 1</li>
        <li>Item 2</li>
        <li>Item 3</li>
    </ul>
</p>
iFoundSilentHouse commented 6 months ago
-        <ul>
-          <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
-          <li>Added more spacing between links to make them easier to click on small screens</li>
-          <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
-          <li>Streaming button (alpha) for some audio/video file types</li>
-        </ul>
+        <p>
+          <ul>
+            <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
+            <li>Added more spacing between links to make them easier to click on small screens</li>
+            <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
+            <li>Streaming button (alpha) for some audio/video file types</li>
+          </ul>
+        </p>

Failed with same error

tfuxu commented 5 months ago

~I don't know how the packaging works in void, but can you use validate-relax in appstream-util?~

Try patching data/meson.build line 50 by replacing validate with validate-relax.

iFoundSilentHouse commented 5 months ago

It worked! Thank you. Should I use it as main patch for void package?

iFoundSilentHouse commented 5 months ago

Also, I can add this as a commit in this pr. Is it needed?

ranfdev commented 5 months ago

thanks everyone