ranger / ranger

A VIM-inspired filemanager for the console
https://ranger.fm
GNU General Public License v3.0
15.47k stars 889 forks source link

set colorscheme update colorscheme partially #2760

Open Desiment opened 1 year ago

Desiment commented 1 year ago

Runtime Environment

Current Behavior

set colorscheme command does not work properly. It changes colorschme only partially. I created two simple colorschemes, for which method use() return either (0,0,normal) (zenlight) or (255, 255, normal) (zendark). After running ranger with the light colorscheme I get (as excepted):

image

But after execution `set colorscheme darktest, I get: image

It seems that ranger applies colorscheme only in directories that were not visited before setting a new colorscheme (here I switched to some random directory): image

This work with default colorschemes too. Also, I tested this in kitty and noticed the same thing.

Expected Behavior

Running with darktest colorscheme gives image

So getting this after running set colorscheme zendark is (I think) expected behavior.

Steps to reproduce

  1. Run ranger with some colorscheme
  2. Change colorscheme
toonn commented 1 year ago

Yeah, this is a known bug. Thanks for the report though. Kinda has a low priority for us since changing the colorscheme while running Ranger doesn't occur that often. PRs welcome though : )